Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValueError: mutable default for field add_maker is not allowed: use default_factory #387

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 7, 2023

5bebe85 fix ValueError: mutable default <class 'tests.core.test_maker.NotAMaker'> for field add_maker is not allowed: use default_factory
22be429 ruff . --fix
035429e bump pre-commit ruff to v0.0.282
c4e9530 revert auto-fix RUF013: PEP 484 prohibits implicit Optional

…er'> for field add_maker is not allowed: use default_factory
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #387 (035429e) into main (befebb7) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 035429e differs from pull request most recent head c4e9530. Consider uploading reports for the commit c4e9530 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          19       19           
  Lines        1439     1439           
  Branches      364      364           
=======================================
  Hits         1437     1437           
  Misses          1        1           
  Partials        1        1           
Files Changed Coverage Δ
src/jobflow/core/flow.py 100.00% <ø> (ø)
src/jobflow/core/job.py 100.00% <ø> (ø)
src/jobflow/utils/graph.py 97.61% <ø> (ø)
src/jobflow/core/reference.py 100.00% <100.00%> (ø)
src/jobflow/core/store.py 100.00% <100.00%> (ø)
src/jobflow/managers/fireworks.py 100.00% <100.00%> (ø)
src/jobflow/utils/find.py 100.00% <100.00%> (ø)

@janosh janosh merged commit 108d2f4 into main Aug 7, 2023
6 checks passed
@janosh janosh deleted the fix-mutable-dataclass-field branch August 7, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant